• DrM@feddit.de
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    1 year ago

    The main problem with JavaScript and TypeScript is that there is such a little entrybarrier to it, that way too many people use it without understanding it. The amount of times that we had major issues in production because someone doesn’t understand TypeScript is not countable anymore and our project went live only 4 months ago.

    For example, when you use nest.js and want to use a boolean value as a query parameter.

    As an example:

    @Get('valueOfMyBoolean')
    @ApiQuery(
      {
        name: 'myBoolean',
        type: boolean,
      }
    )
    myBooleanFunction(
      @Query('myBoolean') myBoolean: boolean
    ){
      if(myBoolean){
        return 'myBoolean is true';
      }
      return 'myBoolean is false';
    }
    

    You see this code. You don’t see anything wrong with it. The architect looks at it in code review and doesn’t see anything wrong with it. But then you do a GET https://something.com/valueOfMyBoolean?myBoolean=false and you get “myBoolean is true” and if you do typeOf(myBoolean) you will see that, despite you declaring it twice, myBoolean is not a boolean but a string. But when running the unit-tests, myBoolean is a boolean.

    • jpeps@lemmy.world
      link
      fedilink
      arrow-up
      1
      ·
      10 months ago

      Typically when creating API interfaces you’d be better off marking the inputs as unknown, and then using something like Zod to validate the types