Had a team lead that kept requesting nitpicky changes, going in a FULL CIRCLE about what we should change or not, to the point that changes would take weeks to get merged. Then he had the gall to say that changes were taking too long to be merged and that we couldn’t just leave code lying around in PRs.
Had a team lead that kept requesting nitpicky changes, going in a FULL CIRCLE about what we should change or not, to the point that changes would take weeks to get merged. Then he had the gall to say that changes were taking too long to be merged and that we couldn’t just leave code lying around in PRs.
Jesus fucking Christ.
There’s a reason that team imploded…
Had a colleague who would comment things like “add a newline here” as well as things that were fully his own preference.
That was the only time I closed comments without replying to them or fixing them, without feeling bad.
For stuff like that, it’s best to have an auto formatter like checkstyle or something.
My point exactly! But naw, several others on the team insisted this guy policing others manually is better than putting a linter in the pipeline.
I don’t work there anymore, this is one of the (minor) reasons.
People need to lameduck their code more
People need to reply to those comments with “out of scope” and a link to a new issue that will get buried in the backlog more often