Had a team lead that kept requesting nitpicky changes, going in a FULL CIRCLE about what we should change or not, to the point that changes would take weeks to get merged. Then he had the gall to say that changes were taking too long to be merged and that we couldn’t just leave code lying around in PRs.
I’ll add a refactor task to the backlog filed under “tech debt”
please confirm again that you know we are still behind on security updates and that you’re ok with it because you are responsible for how I spend my hours
I’d like more time to spend on bugs before we lose customers.
Also I won’t touch that buggy part without taking the time for a rewrite because we did it “fast” per your request and it’s so hard to maintain now that it becomes a time sink on every minor change
I know we are under time pressure right now, but as a stakeholder I request we plan a few sprints for improving reliability of our product
It’s not “fun” to work on our code. We might lose developers if we do not address this. We both know the good coders will have no problem finding a new job and you’ll end up with the bad ones.
Either that, or plan for loss of personnel and the extra time we need for the hiring process and the loss of developer hours
TFW you want to do things good, slow and expensive, but management makes you do them fast, cheap and crap.
For your entire career.
Please kill me
No, you still have a PR to review.
> someone nitpicks word you used in a variable declaration
> you change it
> someone more senior says the former made more sense
> this goes on for far longer than it should
> eventually you get a real review from someone in your team that identified something actually needs to change
> you change it and re request reviews
rinse and repeat
Had a team lead that kept requesting nitpicky changes, going in a FULL CIRCLE about what we should change or not, to the point that changes would take weeks to get merged. Then he had the gall to say that changes were taking too long to be merged and that we couldn’t just leave code lying around in PRs.
Jesus fucking Christ.
There’s a reason that team imploded…
Had a colleague who would comment things like “add a newline here” as well as things that were fully his own preference.
That was the only time I closed comments without replying to them or fixing them, without feeling bad.
For stuff like that, it’s best to have an auto formatter like checkstyle or something.
My point exactly! But naw, several others on the team insisted this guy policing others manually is better than putting a linter in the pipeline.
I don’t work there anymore, this is one of the (minor) reasons.
People need to lameduck their code more
People need to reply to those comments with “out of scope” and a link to a new issue that will get buried in the backlog more often
Don’t forget get questioned by your manager/scrum lead as to why its taking so long to get out.
Well, I’ve had the PR ready for 3 days and the team asked me to make changes today
you forgot the part where you have to rebase your branch and that causes merge conflicts that were resolved later but somehow still persist.
Are you me?
Change management! :-)
Or, if possible, change employer.
(And I know we’re in meme-land, but I always see it as a developer’s task to inform of the trade-off between fast and good)
Every other skilled trade just says “Fast, Right, or Cheap: pick two.”
It’s not my fault if they always pick fast and cheap
Okay, sure, do fast. Then:
i got the sense that some people wanted to when i made this same point about this industry in this same community about a week or so ago.
i love the duality of lemmy sometimes. lol